I saw that same F18 instructor pilot damn near crash a archer when I was giving him his civillian IPC and BFR. But I would not say that ALL mil. pilots in general are better pilots. Because that just simply isnt true. Way too many variables to say that in general, military pilots are always better. Top of their class? Some of the better pilots in the world? Yeah, but better than all civi pilots. No.
And you are judging his skills skills on an Archer which he probably hadn't flown before (or rarely). If he was an F/A-18 guy - - I can promise you that he has done some more complicated flying, and succeeded, than what is required in an Archer at any moment in time. This line of thinking is no different than if I took you and your experience and put you in the simulator behind the carrier (as I have had the opportunity to do many times) and watch those pilots flail on what should be a simple ILS type approach until 3/4 of a mile behind the boat and then take over a visual approach.
I will agree with the premise of your post - too many variables to make general statements, but at the same time, you seem fine with pointing out a singular occurance to try and make some point just because the guy was a Hornet pilot. I have shared my experiences on this board with my transition into professional flying and the challenges that I encountered. I ahev said that I am probably from the absolute WORSE background possible for my current job, but one thing that I learned/brought from my military flying is the being *trainable*. Although I might not bring the skills that others might already have (for instance USAF heavy pilots), I can learn these new skills quickly and I am adaptable to the different environment.
And being ahead with money? Well thats just depends on ones pay and financial decision making. In the military a lot of costs are covered for you but that doesn't mean you cant get in debt or burn through your money.
Yes - there are people in the military with debt. I ran across many of them and it is unfortunate. I think you are over thinking what rickair was trying to say though and taking everything to literally. If you joined the military and learned to fly, then you are probably not saddled with the legendary $100,000+ ERAU/UND/etc... pile of debt when just starting out that, which according to this board, is stifling and crushing and never allows a pilot to get on their feet and start building a life. Not that this notion isn't full of generalizations as we know there are pilots out there who have handled this situation just fine too and are making a go of it full steam ahead.