Is there a "shortage" of domestic students or US student pilots here?
I would say no. As of today, there are still lots of hireable guys on the street or other jobs that actually pay for various reasons.

I would say if you looked at most flight schools today, you would see a large foreign student base with a very small domestic group of students.
Loans to pay for the zero to hero schools and now the new 1500 hour ATP rule taking effect August 1st, (in two days!) it will only decrease the already small sample of domestic US student pilots in US flight schools.

If a new student were to start today with all the financing or cash to pay, yes you could be 'hireable' in 2 to three years yes, (zero to flight instructor, gain 1500 and complete the new ATP program) hours depending on how you define quality of life and hireability.