It seems you will be answering your own question as you begin training..
You will have different Instructors all of whom will show you first hand what makes a "good" CFI or not.
Pay attention and emulate what works while making sure to never do in your CFI days those things that you found to be undesirable or that had a negative effect on your training experience.
Later, watch and do the same with every Captain you fly with. Catalog those experiences and use them in the same manner as above when it is time to upgrade.
Have Fun all along the way, it's just " airplane stuff "...
Stimpy