The instructor gig is pretty good in that your home life is usually much better; the schoolhouse IP's (which I am currently) don't fly overseas missions frequently if at all.

BUT... if you want to get promoted, you still have to do the non-flying BS that shows your interest in advancement (Professional Military Education, or PME; staff/office tours, etc).

I have no doubt that your friend had a good time, but ask him about promotion opportunities versus being just a line pilot and doing nothing else.

Again, as long as you know what you're getting into, the life can be pretty good in the military.