As others have said, 2 year upgrades at Colgan don't exist anymore. I would GUESS more like 3-5 years. And unless Key Lime is so bad, they can't keep people, I would question the 12 month to a Metro promise.
Another 1000 hours instructing will not improve your chances to get hired with almost any airline; but, as slowly as hiring is going right now, where ever you go, you will be at the bottom of the seniority for a LONG time. Be sure the life you have at your new job is an improvement over instructing. You will probably be sitting a bunch of reserve making $18,900 the first year at Colgan.... and commuting to reserve SSucksS! And a big unknown for Colgan is the contract: when will we get one and what will it be like.
I flew 135 for several years and liked it. Great experience if you don't do something stupid and kill yourself (if you know the regs, the airplane's limitations, the wx, the terrain, and how to fly ugly IFR, you will do fine.) Flying the 'jo in Colorado could be exciting.... especially single engine! After that, flying coupled ILSs in an RJ will be boring. If they offered a base that I liked, I would be tempted.
I DO NOT like the "First officer training program" (aka Pay to play) that Key Lime has, but that is just my opinion. Remember though, if the program attracts many people, when you do go to the Metro, you will be MEI-ing any idiot with 10,000 bucks burning a hole in his pocket. I wouldn't want to do that in a 15,000 pound aircraft, in the mountains, while trying to keep a schedule.... but that is just me.
Good luck