I used to fly 135 night freight and then left aviation for four years. Having been back in aviation for the past two years, while working a desk job part-time, I can say unequivocally that I'm in aviation for the long-term. I contemplated leaving flying again but I just couldn't do it. The positives outweigh the negatives and working a desk job just isn't for me. I regretted leaving aviation once before and I don't want to leave again only to regret it.
I enjoy my regional gig but it's a means to an end. More than likely, this will be my only airline stop in my career. Hopefully, I can pull off a gig flying out on the West Coast and with an employer that offers decent pay and QOL. For me, at least, it's not what I fly that's important - it's QOL.
We all have to live our own lives as we see fit. For some of us, our happiness is about following our passion of flying while accepting the inherent instability and pay issues. For others, those issues of instability and pay are enough to cause them to leave flying. I won't begrudge those that quit flying. They are doing what they feel is right.
For me, what's right is staying with flying and having fun as I progress in my career!
No one gets off this rock alive so make the best of your life.
SF